Skip to content

Bump dependencies from commit fa2686 - #2913

Merged
A5rocks merged 4 commits into
masterfrom
autodeps/bump_from_fa2686
Dec 26, 2023
Merged

Bump dependencies from commit fa2686#2913
A5rocks merged 4 commits into
masterfrom
autodeps/bump_from_fa2686

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

No description provided.

pre-commit-ci Bot and others added 2 commits December 25, 2023 21:11
updates:
- [github.com/psf/black-pre-commit-mirror: 23.12.0 → 23.12.1](psf/black-pre-commit-mirror@23.12.0...23.12.1)
- [github.com/astral-sh/ruff-pre-commit: v0.1.8 → v0.1.9](astral-sh/ruff-pre-commit@v0.1.8...v0.1.9)
@github-actions github-actions Bot added the dependencies Pull requests that update a dependency file label Dec 26, 2023
@github-actions
github-actions Bot enabled auto-merge (squash) December 26, 2023 02:26
@CoolCat467

Copy link
Copy Markdown
Member

This is the autodeps run for #2912

@codecov

codecov Bot commented Dec 26, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (683f5cb) 99.65% compared to head (1349390) 99.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2913   +/-   ##
=======================================
  Coverage   99.65%   99.65%           
=======================================
  Files         115      115           
  Lines       17310    17310           
  Branches     3110     3110           
=======================================
  Hits        17251    17251           
  Misses         40       40           
  Partials       19       19           
Files Coverage Δ
src/trio/_subprocess.py 100.00% <100.00%> (ø)

@CoolCat467
CoolCat467 disabled auto-merge December 26, 2023 04:14

@A5rocks A5rocks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, commentary

Comment thread test-requirements.txt
# pip-compile test-requirements.in
#
aiohttp==3.9.1
# via black

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Surprised that black used to require aiohttp!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was slightly concerned when I saw a bunch of dependencies no longer required and looked into it myself as well, and apparently something with hatchling had a bug somewhere and had extra dependencies counting towards default installation dependencies or something around those lines, and the new release of black resolves those issues. ("extra" dependencies I am referring to (they probably have a proper name but I have forgotten it) are that feature where you can specify your package like idlemypyextension[user] instead of just idlemypyextension and the [user] one will install more dependencies)

Comment thread src/trio/_subprocess.py
async def __aenter__(self) -> Self:
return self

# Type ignore is for `Type of decorated function contains type "Any" ("Callable[[Process], Coroutine[Any, Any, None]]")`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a mypy bug :'(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I thought so too, but I haven't made a bug report for it as of writing.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be an issue in _deprecate.deprecate that didn't surface previously, but idk.

@A5rocks
A5rocks merged commit 7642383 into master Dec 26, 2023
@A5rocks
A5rocks deleted the autodeps/bump_from_fa2686 branch December 26, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants