Forward pool timeouts to polling error callbacks - #5337
Open
Mmx233 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes connection-pool exhaustion observable through polling error callbacks without changing the handling of regular request timeouts.
HTTPXRequestcurrently mapshttpx.PoolTimeouttoTimedOut. The polling retry loop intentionally handles everyTimedOutas an expected request timeout and retries it silently. As a result,Updater.start_polling(error_callback=...)cannot distinguish or react to a request that was never sent because no connection was available from the pool.The change introduces
telegram.error.PoolTimeoutas a subclass ofTimedOut, translateshttpx.PoolTimeoutto that backend-independent exception, and forwards onlyPoolTimeoutto the polling error callback. Existingexcept TimedOutandisinstance(error, TimedOut)checks remain compatible, while regular long-poll timeouts retain their current behavior.Check-list for PRs
Added
.. versionadded:: NEXT.VERSION,.. versionchanged:: NEXT.VERSION,.. deprecated:: NEXT.VERSIONor.. versionremoved:: NEXT.VERSIONto the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)Created new or adapted existing unit tests
Documented code changes according to the CSI standard
Added myself alphabetically to
AUTHORS.rst(optional)Added new classes & modules to the docs and all suitable
__all__sChecked the Stability Policy in case of deprecations or changes to documented behavior
If Relevant