Merged
Conversation
Bibo-Joshi
reviewed
Jun 25, 2022
harshil21
reviewed
Jun 25, 2022
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
harshil21
reviewed
Jun 26, 2022
Co-authored-by: Harshil <37377066+harshil21@users.noreply.github.com>
harshil21
approved these changes
Jun 26, 2022
Member
|
Why is pre-commit failing? I thought we had managed that in #3027? |
Member
Author
|
Is it the same error or was it a different one? |
Member
|
On this PR it's telegram/__main__.py:44: error: unused 'type: ignore' comment
Found 1 error in 1 file (checked 155 source files)on #3027 it was telegram/__main__.py:44: error: Module has no attribute "__version__" [attr-defined]
Found 9 errors in 2 files (checked 155 source files) |
Member
Author
|
Yeah I don't know, it works perfectly for pycharm, and it definitely fails locally when I remove the comment. Oh hey look at that it works on CI without it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same PR as #3112, just with V13