Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Numeric prerelease and build identifiers accepted by
Version.parsecan still fail when bumped: a 5000-digit identifier raises Python's integer string conversionValueError. The comparison path already avoids that limit following #487/#488.Increment ASCII decimal strings directly and reuse the helper for prerelease bumps, build bumps, and the old-style
rc3branch ofnext_version. Carry propagation works without changing the process-wide conversion limit. Existing build zero padding and constructor Unicode-digit behavior are preserved.Regression tests cover all three paths with no carry, a carry chain, and an extra output digit; all nine fail before the fix. Full test/doctest suites pass under tox on Python 3.10 through 3.15 (498 passed, 1 skipped per interpreter). The repository-wide ruff check currently fails with existing diagnostics; comparing the unmodified source and this patch produces the same 160 diagnostics and no new diagnostics. The
pr494.bugfix.rstchangelog fragment is included; tox changelog check and draft build pass.