Repository navigation
Conversation
MbappeWU
marked this pull request as ready for review
October 5, 2026 13:11
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documented
tox -e docscommand resolvesmakeas a Python package throughuvx. That package provides no executable, so the docs flow exits before invoking the already available GNU Make or Sphinx.Run
make -C docs htmldirectly and remove the unuseduvxexternal allowlist entry. The existing Makefile still setsPYTHONPATH=../srcand uses the original tox docs dependencies. No Makefile, dependency, package, or workflow changes are needed.Validation:
Exact original tox docs flow on the canonical base installs the declared dependencies, invokes
uvx make, and exits 1 withPackage make does not provide any executables.Exact repaired
tox -e docs, with fresh generated output and no command override: exit 0 on Python 3.12.13, tox 4.64.8, Sphinx 7.0.1 and GNU Make 3.81. It processes all 44 sources and produces 47 HTML files. The 12,953-byteindex.htmlexists and its title parses correctly.Config/code review approves; no runtime or other source bytes change. Earlier missing-tool attempts are kept separate from the executed original failure.
Add the required
pr490.bugfix.rstnewsfragment using the actual PR number; Towncrier 25.8.0 check passes.The original Python workflow path filter excludes this tox/RST-only diff, so no Python run is reported for this head. The upstream CodeQL run requires maintainer approval. No skipped or absent test run is recorded as passed.