Skip to content

Fix #203: Use --check option for black (infra)#204

Merged
s-celles merged 1 commit into
python-semver:masterfrom
tomschr:feature/203-gh-action-black-check
Nov 25, 2019
Merged

Fix #203: Use --check option for black (infra)#204
s-celles merged 1 commit into
python-semver:masterfrom
tomschr:feature/203-gh-action-black-check

Conversation

@tomschr
Copy link
Copy Markdown
Member

@tomschr tomschr commented Nov 25, 2019

This PR contains the following changes:

  • Remove uploading the diff file as artifact
  • Use --check to test our source code

I haven't provided an entry in the CHANGELOG. It doesn't affect the source code and it's not bound to a specific release, so I thought I skip this. Hope this is ok. 😉

* Remove uploading the diff file as artifact
* Use `--check` to test our source code
@tomschr tomschr added Infra All about infrastructure (GitHub Action, project build etc.) Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness labels Nov 25, 2019
@tomschr tomschr requested review from ppkt and s-celles November 25, 2019 08:45
@tomschr tomschr self-assigned this Nov 25, 2019
@s-celles s-celles merged commit 8169c12 into python-semver:master Nov 25, 2019
@tomschr tomschr deleted the feature/203-gh-action-black-check branch November 25, 2019 09:25
@ppkt
Copy link
Copy Markdown
Member

ppkt commented Nov 25, 2019

it's too late but it looks good, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Not a bug, but increases or improves in value, quality, desirability, or attractiveness Infra All about infrastructure (GitHub Action, project build etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants