Skip to content

Move to GH org - #178

Merged
s-celles merged 7 commits into
masterfrom
scls19fr-move-to-gh-org
Nov 5, 2019
Merged

Move to GH org#178
s-celles merged 7 commits into
masterfrom
scls19fr-move-to-gh-org

Conversation

@s-celles

@s-celles s-celles commented Nov 5, 2019

Copy link
Copy Markdown
Member

Related #177

@s-celles
s-celles requested a review from tomschr November 5, 2019 08:36
@s-celles

s-celles commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

CI builds are now available at
https://travis-ci.com/python-semver/python-semver

@tomschr could you tell me if I miss a link to fix?

@tomschr tomschr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @scls19fr thanks for the changes. Looks good from my side! 👍

I only have one comment.

I would like to see a notice somewhere mentioning that the links has changed now. Not sure if this should be covered in this PR or in another one.

@s-celles

s-celles commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

I've just added this to CHANGELOG to keep a track.

@tomschr

tomschr commented Nov 5, 2019

Copy link
Copy Markdown
Member

Good idea with the CHANGELOG, I didn't think of that. 😉 However, I would suggest a more prominent place, maybe somewhere in the README? Something like that:

.. note::

   With version 2.9.0, we changed the GitHub project. The project is now
   located under a separate domain ``python-semver``. The complete
   URL is::

       https://github.com/python-semver/python-semver

   If you still have an old repository, correct your upstream URL to the new URL::

       git remote set-url upstream git@github.com:python-semver/python-semver.git

@s-celles
s-celles merged commit e2b07af into master Nov 5, 2019
@s-celles

s-celles commented Nov 5, 2019

Copy link
Copy Markdown
Member Author

ok I let you create a PR to add this to doc because I don't know exactly where you prefer it to be.

@tomschr
tomschr deleted the scls19fr-move-to-gh-org branch November 5, 2019 11:59
@tomschr

tomschr commented Nov 5, 2019

Copy link
Copy Markdown
Member

Sure, no problem. 👍 Thanks for merging.

@tomschr

tomschr commented Nov 5, 2019

Copy link
Copy Markdown
Member

I don't know exactly where you prefer it to be.

@scls19fr I will open a pull request especially for you. 😉

tomschr added a commit to tomschr/python-semver that referenced this pull request Nov 5, 2019
tomschr added a commit to tomschr/python-semver that referenced this pull request Nov 5, 2019
s-celles pushed a commit that referenced this pull request Nov 5, 2019
* Mentioned in #177 and #178
* Update CHANGELOG.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants