fix: issue with tomlkit 0.7.2#346
Closed
browniebroke wants to merge 4 commits into
Closed
Conversation
8f8b6d1 to
cf056d0
Compare
browniebroke
commented
Jun 9, 2021
Comment on lines
+251
to
+263
| """ | ||
| [tool.poetry] | ||
| name = "my-package" | ||
| version = "0.1.0" | ||
| description = "A super package" | ||
|
|
||
| [build-system] | ||
| requires = ["poetry-core>=1.0.0"] | ||
| build-backend = "poetry.core.masonry.api" | ||
|
|
||
| [tool.semantic_release] | ||
| version_toml = "pyproject.toml:tool.poetry.version" | ||
| """ |
Contributor
Author
There was a problem hiding this comment.
I dug into this, but I can't find an appropriate fix in PSR. I tried to update it via tomlkit only, and it works, but tomlkit + dotty-dict seems to be the problem.
One thing to note is that this is a case of an out-of-order table, which is discouraged by the TOML spec:
Defining tables out-of-order is discouraged.
# VALID BUT DISCOURAGED [fruit.apple] [animal] [fruit.orange]# RECOMMENDED [fruit.apple] [fruit.orange] [animal]
If the table is as recommended in the specs, the test passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tomlkit