Skip to content

fix:update click and tomlkit#339

Merged
danth merged 1 commit into
python-semantic-release:masterfrom
lyz-code:fix/update-click-and-tomlkit
Jun 8, 2021
Merged

fix:update click and tomlkit#339
danth merged 1 commit into
python-semantic-release:masterfrom
lyz-code:fix/update-click-and-tomlkit

Conversation

@lyz-code
Copy link
Copy Markdown
Contributor

@lyz-code lyz-code commented Jun 8, 2021

No description provided.

@danth danth merged commit 947ea3b into python-semantic-release:master Jun 8, 2021
Comment thread setup.py
"wheel",
"python-gitlab>=1.10,<3",
"tomlkit==0.7.0",
"tomlkit==0.7.2",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this was pined to 0.7.0 as it seems it was causing a bug where the pyproject.toml was being wiped.

Should probably have left a comment or even better write a test reproducing the problem... 😞

danth added a commit that referenced this pull request Jun 8, 2021
@grawlinson
Copy link
Copy Markdown

Has this issue been reported upstream?

@browniebroke
Copy link
Copy Markdown
Contributor

So it turns out to be a problem only when the TOML file has out-of-order tables. The spec discourages them ("Defining tables out-of-order is discouraged."), but they are considered valid.

I tried to look at tomlkit, but it has several tests for them, and it seems to work fine on its own. However, when used with dotty-dict -like it's used in PSR- we see the problem from #336, so I'm not too sure to which upstream this should be reported: tomlkit or dotty-dict...

I've added a test case in #349, to make sure we get the right behaviour in PSR (at least).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants