fix: use resolve() instead of absolute() in verify_git_repo_dir#1444
Open
aconal-com wants to merge 1 commit into
Open
fix: use resolve() instead of absolute() in verify_git_repo_dir#1444aconal-com wants to merge 1 commit into
aconal-com wants to merge 1 commit into
Conversation
c6ec517 to
b1868fd
Compare
In monorepo setups where repo_dir='..' is configured for a subpackage,
Path('..').absolute() returns /path/to/package/.. rather than the resolved
/path/to/repo. Using resolve() properly handles symlinks and normalizes
paths, preventing false 'Found .git/ in higher parent directory' warnings.
Fixes python-semantic-release#1418
b1868fd to
bf5fdff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In monorepo setups where
repo_dir='..'is configured for a subpackage,Path('..').absolute()returns/path/to/package/..rather than the resolved/path/to/repo. Usingresolve()properly handles symlinks and normalizes paths, preventing false 'Found .git/ in higher parent directory' warnings.Fixes #1418