Added floodlight lights and siren support#58
Merged
Conversation
Member
|
Awesome guys!! Thanks for your contribution @jsetton and for testing @subnetangel. Good teamwork guys!! Thanks!! |
tchellomello
approved these changes
Oct 17, 2017
tchellomello
left a comment
Member
There was a problem hiding this comment.
Looks good!! Thank you for your contribution @jsetton
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to get the status and also control the floodlight lights and siren.
The siren is controllable by setting a duration in seconds which I currently limited in the code to a maximum of 2 minutes at a time. This is the current behavior when pressing on the siren button in the app without manually turning it off, based on my conversation with the Ring support team. When setting that duration to 0, it is considered as an off command.
I was able to test turning on and off the lights on my floodlight cam but since I live in a dense neighborhood, I cannot test the siren without bothering my neighbors very easily. If someone have a way to test that functionality without disturbing other than yourself, that would be great.
Related: #38