Expose all the batteries that a device might have. Add test cases.#524
Open
sbeitzel wants to merge 2 commits into
Open
Expose all the batteries that a device might have. Add test cases.#524sbeitzel wants to merge 2 commits into
sbeitzel wants to merge 2 commits into
Conversation
Modify test to prove that we're actually using the reported active battery if there is one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the requested feature from #523
The main risk with this is that the changed property in
doorbot.py,battery_lifenow reports only the status of the active battery in a multi-battery device. Before the change, a camera with two batteries, one at 25% and one at 80%, would return the value 100 (since 25 + 80 = 105, but the value is capped at 100), while after this change, the reported value would depend on which was the currently active battery.