Skip to content

adds support for stickup & floodlight cams#44

Merged
tchellomello merged 3 commits into
python-ring-doorbell:masterfrom
jlippold:master
Sep 27, 2017
Merged

adds support for stickup & floodlight cams#44
tchellomello merged 3 commits into
python-ring-doorbell:masterfrom
jlippold:master

Conversation

@jlippold

Copy link
Copy Markdown
Contributor

No description provided.

@mention-bot

Copy link
Copy Markdown

@jlippold, thanks for your PR! By analyzing the history of the files in this pull request, we identified @tchellomello to be a potential reviewer.

Comment thread ring_doorbell/__init__.py
self.debug = self._ring.debug
self.family = 'stickup_cams'
self.name = name
self.update() No newline at end of file

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no newline at end of file

Comment thread ring_doorbell/__init__.py
self.update()
return True

class RingStickUpCam(RingDoorBell):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

expected 2 blank lines, found 1

@coveralls

coveralls commented Jun 24, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 1fe2a9c on jlippold:master into 84e0a6c on tchellomello:master.

@coveralls

coveralls commented Jun 24, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 6aa6042 on jlippold:master into 84e0a6c on tchellomello:master.

Comment thread ring_doorbell/__init__.py
self.update()
return True

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blank line contains whitespace

@coveralls

coveralls commented Sep 27, 2017

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 100.0% when pulling 8a3f276 on jlippold:master into b04e4c3 on tchellomello:master.

@tchellomello tchellomello merged commit 5b7f65c into python-ring-doorbell:master Sep 27, 2017
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants