Skip to content

Fix broken links in readme#426

Merged
sdb9696 merged 4 commits into
python-ring-doorbell:masterfrom
briangoldstein:docs-update
Sep 2, 2024
Merged

Fix broken links in readme#426
sdb9696 merged 4 commits into
python-ring-doorbell:masterfrom
briangoldstein:docs-update

Conversation

@briangoldstein
Copy link
Copy Markdown
Contributor

The following updates have been made to the the readme:

  • Corrected the two readthedocs contributing links
  • Changed the test.py and test_sync.py links to be explicit. They worked in github but 404ed on readthedocs

@coveralls
Copy link
Copy Markdown

coveralls commented Sep 2, 2024

Coverage Status

coverage: 78.829%. remained the same
when pulling e9f7cbe on briangoldstein:docs-update
into c85e4b6 on python-ring-doorbell:master.

Copy link
Copy Markdown
Member

@sdb9696 sdb9696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for this. Let's use the latest links though for contributing as they're built from master.

Comment thread README.rst Outdated
Comment thread README.rst Outdated
briangoldstein and others added 2 commits September 2, 2024 10:05
Co-authored-by: Steven B. <51370195+sdb9696@users.noreply.github.com>
Co-authored-by: Steven B. <51370195+sdb9696@users.noreply.github.com>
@sdb9696 sdb9696 changed the title Readme broken link repair Fix broken links in readme Sep 2, 2024
@sdb9696 sdb9696 merged commit 7a817b3 into python-ring-doorbell:master Sep 2, 2024
@sdb9696
Copy link
Copy Markdown
Member

sdb9696 commented Sep 2, 2024

Many thanks for the PR @briangoldstein!

@briangoldstein briangoldstein deleted the docs-update branch September 2, 2024 20:45
@sdb9696 sdb9696 added this to the 0.9.4 milestone Sep 5, 2024
@sdb9696 sdb9696 mentioned this pull request Sep 5, 2024
sdb9696 added a commit that referenced this pull request Sep 5, 2024
## [0.9.4](https://github.com/python-ring-doorbell/python-ring-doorbell/tree/0.9.4) (2024-09-05)

[Full Changelog](0.9.3...0.9.4)

**Release highlights:**

- Migrate from poetry to uv for package management
- Bugfixes for in-home-chime

**Implemented enhancements:**

- Add WebRTC live streaming session generation [\#348](#348) (@sdb9696)

**Fixed bugs:**

- Fix in-home chime duration setter [\#428](#428) (@briangoldstein)

**Documentation updates:**

- Fix broken links in readme [\#426](#426) (@briangoldstein)

**Project maintenance:**

- Migrate to uv and add testpypi publishing [\#430](#430) (@sdb9696)
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants