0.1.4#42
Merged
Merged
Conversation
tchellomello
commented
Apr 30, 2017
Member
- Rebasing dev to master
- Added contributing guide
- Handle pickle exceptions
* Make session token reusable across multiple object instances via cache file. With this patch, we can have more than one Ring object pointing to the same cache file to share credentials to avoid multiple authentications. * Added unittest for utils.py * Make sure if a different username is used, a new cache should be initialized.
* Cleaning up tests using tearDown() method * Increased coverage tests
houndci-bot
reviewed
Apr 30, 2017
| if sys.version_info.major == 2: | ||
| self.assertRaises(TypeError, _read_cache, True) | ||
| else: | ||
| self.assertRaises(OSError, _read_cache, True) No newline at end of file |
houndci-bot
reviewed
Apr 30, 2017
| self.assertRaises(TypeError, _read_cache, True) | ||
| else: | ||
| self.assertRaises(OSError, _read_cache, True) | ||
|
|
There was a problem hiding this comment.
blank line at end of file
blank line contains whitespace
1 similar comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.