Drop python 2.7/3.5. Updated readme and test.py examples - #192
Merged
balloob merged 13 commits intoJan 20, 2020
Conversation
Collaborator
|
Let's drop everything but Python 3.6+ |
Contributor
Author
|
Sounds reasonable to me. I will get that updated. |
balloob
reviewed
Jan 19, 2020
balloob
reviewed
Jan 19, 2020
balloob
reviewed
Jan 19, 2020
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
|
Should ringcli.py also be changed to the new auth/methods? |
Contributor
Author
|
@galadril Didn't even realize this file was there. I'll look at it in a couple hours. Thanks. |
balloob
approved these changes
Jan 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed python 2.7 and python 3.5. Min python 3.6+.
Updated the README (AttributeError: 'Ring' object has no attribute 'stickup_cams' #188 and TypeError: __init__() takes 2 positional arguments but 3 were given #190)
Updated test.py examples for the data refactor that @balloob had previously done. (Trouble getting new oauth to work properly. #186 and test.py Line 31 is missing the User-Agent #189)