Skip to content

Handle generic iterables#89

Merged
lelit merged 5 commits into
python-rapidjson:masterfrom
lelit:issue84-v3
Dec 20, 2017
Merged

Handle generic iterables#89
lelit merged 5 commits into
python-rapidjson:masterfrom
lelit:issue84-v3

Conversation

@lelit

@lelit lelit commented Dec 18, 2017

Copy link
Copy Markdown
Contributor

This targets issue #84, automatically dumping generic iterables as arrays.

To overcome the inefficiency in handling generic iterables with the previous stack-based
implementation of the dumps_internal() function, this replaces it with plain recursion so
there's no need to build a temporary list consuming the iterable and then pushing each
item in reverse order.

This targets issue python-rapidjson#84, automatically dumping generic iterables as arrays.

To overcome the inefficiency in handling generic iterables with the previous stack-based
implementation of the dumps_internal() function, this replaces it with plain recursion so
there's no need to build a temporary list consuming the iterable and then pushing each
item in reverse order.
@lelit lelit requested a review from kenrobbins December 18, 2017 17:30
@lelit

lelit commented Dec 18, 2017

Copy link
Copy Markdown
Contributor Author

Sorry @kenrobbins, hit the wrong link... :)

@lelit lelit merged commit fbd3ee1 into python-rapidjson:master Dec 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant