Add support for 1-9 fractional seconds#133
Merged
Merged
Conversation
Contributor
|
Thank you, the patch looks good. I will analyze it better in a couple of days. |
Contributor
|
The failure seems related to a different representation of Once I get to actually merge this I will try to take care of that. |
Contributor
|
Thank you Karl: I've merged this with some cosmetic changes, and fixed the Py36 related glitch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm neither a python nor C a programmer, but the existing tests were helpful. I added a few.
I was able to remove a lot of duplication (it became necessary since a 14-length time could now mean 3 things not just 1). I ran the benchmarks but didn't see any huge difference.