[W.I.P.] Update benchmarks: Drop ujson, add hyperjson, add orjson (issue #130) by hartwork · Pull Request #131 · python-rapidjson/python-rapidjson

hartwork · 2020-02-23T00:05:40Z

For #130

Should not be merged right now because:

in my current results (see updated benchmark tables), stdlib json is 2-3 times faster than rapidjson, not slower. That's unexpected — any ideas what I might be doing wrong? What do you get when you run make benchmarks-tables?
depending on progress at https://github.com/ultrajson/ultrajson-fork/issues/5#issuecomment-590002891 we may want to (a) re-add ujson soon, (b) later or (c) not drop it in the first place

@lelit what do you think?

$ make benchmarks [..] E ModuleNotFoundError: No module named 'rapidjson' make: *** [Makefile:76: benchmarks] Error 4

This addresses issue #130. Thanks to Sebastian Pipping for initial implementation (see PR #131) and research.

lelit · 2020-02-29T09:22:38Z

Hi!

I tried to replicate the problem with ujson, but it works for me (Debian sid here), either with Python 3.7 or Python 3.8... I thus opted to keep it around.

I also did not notice the difference between RJ and standard library json.

OOC, on which OS/hardware did you run the benchmarks?

Anyway, thanks a lot for your initial implementation and research.

hartwork · 2020-02-29T17:05:49Z

I tried to replicate the problem with ujson, but it works for me (Debian sid here), either with Python 3.7 or Python 3.8... I thus opted to keep it around.

The underlying link issue was fixed upstream now at ultrajson/ultrajson#312 . I'm not sure why import does not fail with a link error for you, too.

I expect ujson 2.0.0 to perform rather differently than 1.35 so it might be worth benchmarking against (both ujson 1.35 and) 2.0.0 later.

I also did not notice the difference between RJ and standard library json.

OOC, on which OS/hardware did you run the benchmarks?

16 GB RAM, Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz, 2 cores, 2 threads per core, Gentoo Linux

Closing PR becauce of:

hartwork added 5 commits February 22, 2020 22:07

Makefile: Fix typo (missing "s") in "make help" output

85dd6be

Makefile: Allow "make benchmarks" to find the local rapidjson module

bb460f0

$ make benchmarks [..] E ModuleNotFoundError: No module named 'rapidjson' make: *** [Makefile:76: benchmarks] Error 4

benchmarks: Drop dead ujson

6106512

benchmarks: Add hyperjson and orjson

a4971e7

docs: Regenerate benchmark tables using "make benchmarks-tables"

01f539f

lelit added a commit that referenced this pull request Feb 29, 2020

Add orjson and hyperjson to the benchmarks and renew comparison tables

a5ec68f

This addresses issue #130. Thanks to Sebastian Pipping for initial implementation (see PR #131) and research.

hartwork closed this Feb 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[W.I.P.] Update benchmarks: Drop ujson, add hyperjson, add orjson (issue #130)#131

[W.I.P.] Update benchmarks: Drop ujson, add hyperjson, add orjson (issue #130)#131
hartwork wants to merge 5 commits into
python-rapidjson:masterfrom
hartwork:issue-130-extend-benchmarks

hartwork commented Feb 23, 2020 •

edited

Loading

Uh oh!

lelit commented Feb 29, 2020

Uh oh!

hartwork commented Feb 29, 2020 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

hartwork commented Feb 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lelit commented Feb 29, 2020

Uh oh!

hartwork commented Feb 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

hartwork commented Feb 23, 2020 •

edited

Loading

hartwork commented Feb 29, 2020 •

edited

Loading