Track rapidjson@67a17cf for bugfixes related to JSONSchema validation#103
Merged
Conversation
Contributor
|
Thank you! I'm gonna merge this right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #102 by updating the rapidjson submodule. This is caused by an issue in the library when processing both additionalProperties and patternProperties in a JSONSchema object. This issue was resolved in a PR.
I've included a test that is based on the examples here. The provided example in the issue is also verifies that the behavior is fixed.
I've tracked the library to Tencent/rapidjson@67a17cf to reflect a known stable lua binding in mozilla-services/lua_sandbox_extensions#284. However, commits after (or slightly before) this point should also fix the issue.