Decoder with OrderedDict does not work. #119

Activity

1. lelit commented on Mar 17, 2019

   

   lelit

   on Mar 17, 2019

   Contributor

   More actions

   Thanks for the report.

   Surprisingly, using PyDict_SetItem() on dict subclass such as OrderedDict results in a incomplete dictionary:

   >>> from collections import OrderedDict
   >>> from rapidjson import Decoder
   >>> class OrderedDecoder(Decoder):
   ...     def start_object(self):
   ...         return OrderedDict()
   ... 
   >>> od = OrderedDecoder()
   >>> a = od('{"foo": "bar"}')
   >>> print(a)
   OrderedDict([])
   >>> a == {"foo": "bar"}
   True
2. lelit

   added 2 commits that reference this issue on Mar 17, 2019

   Add failing test on issue #119

   1e0980d

   Use PyDict_CheckExact() to discriminate plain dictionaries from subcl…

   ...

   61d877f
3. spritetong commented on Mar 17, 2019

   

   spritetong

   on Mar 17, 2019

   Last edited by spritetong

   Author

   More actions

   Thank you for your reply.
   >>> a == {"foo": "bar"}
True
   I think because dict.__eq__() method is not overrided by OrderedDict.
4. lelit commented on May 11, 2019

   

   lelit

   on May 11, 2019

   Contributor

   More actions

   Solved in v0.7.1.
5. lelit

   closed this as completedon May 11, 2019