Skip to content

Big Int roundtrip is broken. #112

Closed
Closed
Big Int roundtrip is broken.#112

Description

@sam-s
sam-s
opened on Sep 21, 2018

rapidjson can serialize big integers but cannot deserialize them:

>>> rapidjson.loads(rapidjson.dumps(10**1000))
ValueError: Parse error at offset 0: Number too big to be stored in double

Python 3.7.0
rapidjson.__version__='0.6.3'

Activity

  1. lelit commented on Sep 22, 2018

    @lelit
    lelit
    on Sep 22, 2018
    Contributor

    Thank you: I cannot switch focus right now, but I'll try to understand the issue some time next week.

  2. lelit commented on Sep 26, 2018

    @lelit
    lelit
    on Sep 26, 2018
    Contributor

    I confirm the problem: that error should not happen with the default settings, because we are passing the kParseNumbersAsStringsFlag option to the parser...

    See Tencent/rapidjson#1368

  3. lelit commented on Oct 1, 2018

    @lelit
    lelit
    on Oct 1, 2018
    Contributor

    FYI, it seems the issue does not exist with current master of RapidJSON (see this comment for details).

  4. lelit
    added 2 commits that reference this issue on Feb 11, 2019

    Add failing test for 1e1000 bigint roundtrip (issue #112)

    ae3350b

    Upgrade underlying RJ library to its current master

    0da096d

  5. lelit commented on Feb 11, 2019

    @lelit
    lelit
    on Feb 11, 2019
    Contributor

    Upcoming v0.7 will use current master of underlying rapidjson library, fixing this issue.

    Sorry for the long delay.

  6. lelit
    closed this as completedon Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions