Skip to content

Fix numpy version string parsing#238

Merged
apdavison merged 2 commits into
python-quantities:masterfrom
mscheltienne:np2-fix
Aug 27, 2024
Merged

Fix numpy version string parsing#238
apdavison merged 2 commits into
python-quantities:masterfrom
mscheltienne:np2-fix

Conversation

@mscheltienne

Copy link
Copy Markdown
Contributor

The parsing added in the latest release does not work with development version and breaks MNE workflow here: mne-tools/mne-python#12815

https://github.com/mne-tools/mne-python/actions/runs/10577439355/job/29305416424#step:17:67

@apdavison
apdavison merged commit 4e82387 into python-quantities:master Aug 27, 2024
@apdavison

Copy link
Copy Markdown
Contributor

thanks for this. I'll wait a day or two to see if more bug reports for 0.16.0 come in, then release 0.16.1

@mscheltienne
mscheltienne deleted the np2-fix branch August 27, 2024 13:33
@drammock

Copy link
Copy Markdown
Contributor

thanks for the quick fix @mscheltienne... curious why not switch to packaging.version.parse though? was it hesitation to add a dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants