Repository navigation
Clip F to I conversion to the INT32 range - #10373
Open
usmanmateen wants to merge 2 commits into
Open
usmanmateen wants to merge 2 commits into
usmanmateen wants to merge 2 commits into
Conversation
f2i cast floats to INT32 with no range check. Out-of-range values and NaN are undefined behavior in C, and on x86 they all became -2147483648. Clip to the INT32 range like clip32() in Filter.c, and map NaN to 0 like the F to L and F to I;16 converters.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10372.
Changes proposed in this pull request:
FtoIconversion to theINT32range inf2i, and map NaN to 0. The cast had no range check, so on x86 every value above the range,infandNaNbecame -2147483648, and anIimage at 2147483647 converted toFand back did too. These casts are undefined behavior in C, so the result also depended on the CPU.inf,-infandNaN.With this change, it is 2147483647, the same clipping
clip32()inFilter.cdoes. NaN becomes 0, which is whatFtoLandFtoI;16give.