You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On the other hand we would probably have to go with sudo pip3 install ... to make it work and decrease the maintenance effort. I'm very inclined by this idea as updating the submodules everytime is not very elegant, and the plethora of submodules makes the cloning of this repo very lengthy. And once we lose the magic of a single git clone --recurisve command I think we should go with a makefile so that then a single sudo make install does everything.
A lot of the submodules get deprecated.
astroid: absorbed by prospector.
autopep8: not covered by prospector. Will be kept.
mccabe: absorbed by prospector.
pycodestyle: not covered by prospector; would probably be abandoned due to high maintenance costs.
pydocstyle: absorbed by prospector.
pyflakes: absorbed by prospector.
pylama: deprecated by the adoption of prospector. Also decreases the burden on the development and maintenance of different modules.
pylint: absorbed by prospector.
rope: not covered by prospector. Will be kept (not sure).
six: not covered by prospector. Will be kept (not sure).
snowball_py: deprecated by the adoption of prospector; afaik it is a support tool for other submodules.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Activity
fmv1992 commentedon Aug 12, 2018
Sounds very promising.
It also integrates most of the tools we use so probably we could get rid of the
submodules(at least part of them) as well.fmv1992 commentedon Aug 12, 2018
To wrap-it up:
If we go with
prospector:This issue: how to proceed to clean the hardcoded
logilab-commonfiles from this project? #932 gets deprecated.On the other hand we would probably have to go with
sudo pip3 install ...to make it work and decrease the maintenance effort. I'm very inclined by this idea as updating thesubmoduleseverytime is not very elegant, and the plethora of submodules makes the cloning of this repo very lengthy. And once we lose the magic of a singlegit clone --recurisvecommand I think we should go with amakefileso that then a singlesudo make installdoes everything.A lot of the
submodulesget deprecated.astroid: absorbed byprospector.autopep8: not covered byprospector. Will be kept.mccabe: absorbed byprospector.pycodestyle: not covered byprospector; would probably be abandoned due to high maintenance costs.pydocstyle: absorbed byprospector.pyflakes: absorbed byprospector.pylama: deprecated by the adoption ofprospector. Also decreases the burden on the development and maintenance of different modules.pylint: absorbed byprospector.rope: not covered byprospector. Will be kept (not sure).six: not covered byprospector. Will be kept (not sure).snowball_py: deprecated by the adoption ofprospector; afaik it is a support tool for othersubmodules.See http://prospector.readthedocs.io/en/latest/supported_tools.html.
@diraol, am I missing something?
diraol commentedon Aug 12, 2018
I like make install (without sudo)
I am just not sure about how to proceed to clean the hardcoded
logilab-commonfiles from this project? #932, since I don't know what are we using that dependency for.Submodules:
astroid: Agreeautopep8: Agree to keepmccabe: Agreepycodestyle: I think that this is covered by `prospector, but aliased to pep8pydocstyle: Agreepyflakes: Agreepylama: Agree \o/pylint: Agreerope: It seems to be a dependency commonly used by our users, it looks like we should keep it.six: Not needed if we drop python2 support.snowball_py: I have no idea for what we use it....stale commentedon Jan 10, 2019
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
diraol commentedon Jan 16, 2019
Keeping it up
stale commentedon Jun 15, 2019
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
stale commentedon Jul 6, 2019
Closed due to inactivity.