Skip to content

extend Metar constructor strict to cover all ParserErrors #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
akrherz merged 1 commit into from
Aug 20, 2018
Merged

extend Metar constructor strict to cover all ParserErrors #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions metar/Metar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,13 +324,11 @@ def __init__(self, metarcode, month=None, year=None, utcdelta=None,
provided, then the month and year are guessed from the current date.
utcdelta : int or datetime.timedelta, optional
An int of hours or a timedelta object used to specify the timezone.
strict : bool (default is True) or str {'raise', 'warn', 'log'}
When unparsed or unparseable groups exist in a METAR code, a
``ParserError`` will be raised. Setting this to False will suppress that
behavior and will use the standard library's logging module to record
all supressed errors. One can then detect if decoding is complete by
checking the :attr:`decode_completed` attribute.

strict : bool (default is True)
This option determines if a ``ParserError`` is raised when
unparsable groups are found or an unexpected exception is encountered.
Setting this to `False` will prevent exceptions from being raised and
only generate warning messages.
"""

self.code = metarcode # original METAR code
Expand Down Expand Up @@ -439,9 +437,13 @@ def __init__(self, metarcode, month=None, year=None, utcdelta=None,

except Exception as err:
message = (
"%s failed while processing '%s'\n\t%s" % (handler.__name__, code, "\n\t".join(err.args))
("%s failed while processing '%s'\n\t%s"
) % (handler.__name__, code, "\n\t".join(err.args))
)
raise ParserError(message)
if strict:
raise ParserError(message)
else:
warnings.warn(message, RuntimeWarning)

if self._unparsed_groups:
code = ' '.join(self._unparsed_groups)
Expand Down
7 changes: 7 additions & 0 deletions test/test_metar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,6 +267,13 @@ def report(wind_group):
self.assertEqual( report("MMMMMGMMKT").wind(), "missing" )
self.assertEqual( report("MMMMMG01KT").wind(), "missing" )

def test_issue51_strict(self):
"""Check that setting strict=False prevents a ParserError"""
with warnings.catch_warnings(record=True) as w:
report = Metar.Metar(sta_time+"90010KT", strict=False)
assert len(w) == 1
assert report.wind_speed is None

def test_142_parseWind_illegal(self):
"""Check rejection of illegal wind groups."""
self.raisesParserError( sta_time+"90010KT" )
Expand Down