Skip to content

Ensure T-group temperatures are consistent with previously parsed temperatures #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akrherz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Ensure T-group temperatures are consistent with previously parsed temperatures #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95cc43a
rename Temp1Hour to TempTgroup
akrherz Jul 23, 2024
d9f1d6e
feat: ensure T-group temperatures are consistent
akrherz Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions metar/Metar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ class ParserError(Exception):
(?P<press>\d\d\d)\s+""",
re.VERBOSE,
)
TEMP_1HR_RE = re.compile(
TEMP_TGROUP_RE = re.compile(
r"""^T(?P<tsign>0|1)
(?P<temp>\d\d\d)
((?P<dsign>0|1)
Expand Down Expand Up @@ -882,20 +882,33 @@ def _handlePrecip1hrRemark(self, d):
value = float(d["precip"]) / 100.0
self.precip_1hr = precipitation(value, "IN")

def _handleTemp1hrRemark(self, d):
def _handleTempTgroupRemark(self, d):
"""
Parse a temperature & dewpoint remark group.

These values replace the temp and dewpt from the body of the report.
"""
def _checkT(current, newvalue, label):
"""Helper."""
if current and abs(newvalue - current.value()) > 1:
raise ValueError(
f"{label} from T group ({newvalue:.1f}) does not "
"agree with previously parsed value of "
f"{current.value():.0f}"
)

value = float(d["temp"]) / 10.0
if d["tsign"] == "1":
value = -value
# Ensure that Tgroup value rounds to integer provided temperature
_checkT(self.temp, value, "Temperature")
self.temp = temperature(value)
if d["dewpt"]:
value2 = float(d["dewpt"]) / 10.0
if d["dsign"] == "1":
value2 = -value2
# Ensure that Tgroup value rounds to integer provided dewpoint
_checkT(self.dewpt, value2, "Dew Point")
self.dewpt = temperature(value2)

def _handleTemp6hrRemark(self, d):
Expand Down Expand Up @@ -1084,7 +1097,7 @@ def _unparsedRemark(self, d):
(WIND_SHIFT_RE, _handleWindShiftRemark),
(LIGHTNING_RE, _handleLightningRemark),
(TS_LOC_RE, _handleTSLocRemark),
(TEMP_1HR_RE, _handleTemp1hrRemark),
(TEMP_TGROUP_RE, _handleTempTgroupRemark),
(PRECIP_1HR_RE, _handlePrecip1hrRemark),
(PRECIP_24HR_RE, _handlePrecip24hrRemark),
(PRESS_3HR_RE, _handlePress3hrRemark),
Expand Down
13 changes: 13 additions & 0 deletions test/test_metar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,19 @@ def test_module():
assert hasattr(metar, "__version__")


def test_issue182_conflicting_temperatures():
"""Test that a T-group with conflicting temperatures raises an error."""
# IRL
code = (
"KRDU 081851Z 33003KT 10SM SCT030 SCT120 BKN200 "
"35/24 A3004 RMK T03440339"
)
with pytest.raises(Metar.ParserError):
Metar.Metar(code, 7, 2024, strict=True)
mtr = Metar.Metar(code, 7, 2024, strict=False)
assert mtr.dewpt.value() == 24.0


def test_issue114_multiplebecominggroups():
"""multiple BECMG (becoming) groups should be possible"""
code = (
Expand Down