Skip to content

fix: add code translation to no significant weather, nsw#178

Merged
akrherz merged 2 commits into
python-metar:mainfrom
JordonMaule:main
Aug 31, 2023
Merged

fix: add code translation to no significant weather, nsw#178
akrherz merged 2 commits into
python-metar:mainfrom
JordonMaule:main

Conversation

@JordonMaule

Copy link
Copy Markdown
Contributor

Code tested: VEIM 301200Z 16007KT 7000 NSW SCT018 31/27 Q1007 NOSIG
Before:
image

After:
image

@phobson

phobson commented Aug 30, 2023

Copy link
Copy Markdown
Collaborator

Thanks for PR, @JordonMaule . Do you happen to know if any other keys are missing from that dictionary?

Could you add your example as a test in the test suite?

@JordonMaule

JordonMaule commented Aug 31, 2023

Copy link
Copy Markdown
Contributor Author

@phobson Thank you for your quick reply.
I believe the 'other' codes are all covered.

Most times NSW appears on the end of the bulletin, and is not recognized. (Haven't had the time to review this yet)
But if it's on the middle of the bulletin it matches with the Regex from line 77, and we didn't have the key on WEATHER_OTHER.

I've added tests to all the keys in WEATHER_OTHER, if you'd prefer to have only the NSW code tested let me know and I'll remove the others.

@phobson

phobson commented Aug 31, 2023

Copy link
Copy Markdown
Collaborator

@JordonMaule thanks for the test, looks great!

@codecov-commenter

codecov-commenter commented Aug 31, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (e878b1c) to head (0b814bf).
⚠️ Report is 47 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #178   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files           4        4           
  Lines        1046     1046           
=======================================
  Hits          926      926           
  Misses        120      120           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phobson phobson requested a review from akrherz August 31, 2023 07:45

@akrherz akrherz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the tests!

@akrherz akrherz added this to the 1.11.0 milestone Aug 31, 2023
@akrherz akrherz merged commit b96e901 into python-metar:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants