Codecov Report

Merging #174 (03cd35b) into main (dc582d2) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #174   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files           4        4           
  Lines        1046     1046           
=======================================
  Hits          926      926           
  Misses        120      120           

Thank you. Are you able to add a CI check here for us as well?

Thank you. Are you able to add a CI check here for us as well?

I can do that. I see the current pytest is done through conda and directly coding in installing dependencies in the workflow. If I create a requirements-typing.txt and pin mypy version there, you could use dependabot to control updates. Or keep it simple and just install the latest?

Or keep it simple and just install the latest?

I think you are more knowledgeable and defer to your judgement for what is best.

Added. Im not super familiar with type stubs, but I believe these are only used to signal to downstream applications. I'm not sure that you get the benefit (and pain) of type checking the code inside this package. This is outside the scope of this PR, just wanted to point this out for consideration.

Edit: even if what I said above is true, the benefit of adding the CI check for mypy is that at least the type stubs are internally consistent and valid.

pinging @gamecss on this for input

Sorry :)

Sorry, I don't know if I'm going to say something, but why not merge?