Enable parsing of METARs that list wind and visibility after the sky condition groups.#149
Merged
Merged
Conversation
…TARs that list wind and visibility after the sky condition groups. Fixes python-metar#147.
Codecov Report
@@ Coverage Diff @@
## master #149 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 4 4
Lines 1056 1056
=======================================
Hits 925 925
Misses 131 131
Continue to review full report at Codecov.
|
akrherz
approved these changes
Sep 23, 2021
akrherz
left a comment
Collaborator
There was a problem hiding this comment.
This seems like a reasonable workaround, but await other's comments.
phobson
approved these changes
Oct 4, 2021
phobson
left a comment
Collaborator
There was a problem hiding this comment.
This looks good to me as well.
Collaborator
|
sorry @jhaiduce , do you mind resolving the conflicts? if not, I can do it, no worries. |
Contributor
Author
Done. Should be mergeable now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an extra copy of the wind and visibility, to enable parsing of METARs that list wind and visibility after the sky condition groups.
Fixes #147.