Skip to content

set wind speed defaults when no units provided#140

Merged
akrherz merged 1 commit into
python-metar:masterfrom
akrherz:gh139_default_wind_unit
Sep 1, 2021
Merged

set wind speed defaults when no units provided#140
akrherz merged 1 commit into
python-metar:masterfrom
akrherz:gh139_default_wind_unit

Conversation

@akrherz

@akrherz akrherz commented Sep 1, 2021

Copy link
Copy Markdown
Collaborator
  • For US-sites, default to KT.
  • For all others, default to MPS.

closes #139

- For US-sites, default to KT.
- For all others, default to MPS.

closes python-metar#139
@akrherz akrherz requested review from phobson and tomp September 1, 2021 15:39
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #140 (21060f1) into master (96f6b98) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
+ Coverage   87.44%   87.59%   +0.15%     
==========================================
  Files           4        4              
  Lines        1051     1056       +5     
==========================================
+ Hits          919      925       +6     
+ Misses        132      131       -1     
Impacted Files Coverage Δ
metar/Metar.py 89.89% <100.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f6b98...21060f1. Read the comment docs.

@phobson phobson left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@tomp

tomp commented Sep 1, 2021

Copy link
Copy Markdown
Member

LGTM

@akrherz akrherz merged commit 2f1be43 into python-metar:master Sep 1, 2021
@akrherz akrherz deleted the gh139_default_wind_unit branch September 1, 2021 17:21
@akrherz akrherz added this to the 1.9 milestone Dec 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wind Speeds default to m/s when units are not provided

4 participants