Skip to content

version: support importing under sub-interpreters #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinh-labs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

version: support importing under sub-interpreters #343

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 28 additions & 15 deletions lz4/_version.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,26 +96,39 @@ static PyMethodDef module_methods[] = {
}
};

static int
_version_exec (PyObject *module)
{
#ifdef Py_GIL_DISABLED
PyUnstable_Module_SetGIL (module, Py_MOD_GIL_NOT_USED);
#endif

return 0;
}

static PyModuleDef_Slot _version_slots[] =
{
{Py_mod_exec, _version_exec},
#if PY_VERSION_HEX >= 0x030c0000
/* No state and the LZ4 version calls are reentrant, so _version is safe in
isolated sub-interpreters with their own GIL. */
{Py_mod_multiple_interpreters, Py_MOD_PER_INTERPRETER_GIL_SUPPORTED},
#endif
{0, NULL},
};

static struct PyModuleDef moduledef =
{
PyModuleDef_HEAD_INIT,
"_version",
NULL,
-1,
module_methods
.m_base = PyModuleDef_HEAD_INIT,
.m_name = "_version",
.m_doc = NULL,
.m_size = 0,
.m_methods = module_methods,
.m_slots = _version_slots,
};

PyMODINIT_FUNC
PyInit__version(void)
{
PyObject *module = PyModule_Create (&moduledef);

if (module == NULL)
return NULL;

#ifdef Py_GIL_DISABLED
PyUnstable_Module_SetGIL(module, Py_MOD_GIL_NOT_USED);
#endif

return module;
return PyModuleDef_Init (&moduledef);
}