Skip to content

frame: support importing under sub-interpreters #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jinh-labs wants to merge 1 commit into
base: master
Choose a base branch
from
Open

frame: support importing under sub-interpreters #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 30 additions & 17 deletions lz4/frame/_frame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1654,23 +1654,9 @@ PyDoc_STRVAR(lz4frame__doc,
"A Python wrapper for the LZ4 frame protocol"
);

static struct PyModuleDef moduledef =
{
PyModuleDef_HEAD_INIT,
"_frame",
lz4frame__doc,
-1,
module_methods
};

PyMODINIT_FUNC
PyInit__frame(void)
static int
_frame_exec (PyObject *module)
{
PyObject *module = PyModule_Create (&moduledef);

if (module == NULL)
return NULL;

PyModule_AddIntConstant (module, "BLOCKSIZE_DEFAULT", LZ4F_default);
PyModule_AddIntConstant (module, "BLOCKSIZE_MAX64KB", LZ4F_max64KB);
PyModule_AddIntConstant (module, "BLOCKSIZE_MAX256KB", LZ4F_max256KB);
Expand All @@ -1681,5 +1667,32 @@ PyInit__frame(void)
PyUnstable_Module_SetGIL(module, Py_MOD_GIL_NOT_USED);
#endif

return module;
return 0;
}

static PyModuleDef_Slot _frame_slots[] =
{
{Py_mod_exec, _frame_exec},
#if PY_VERSION_HEX >= 0x030c0000
/* No shared global state: each context is allocated per call, so _frame is
safe in isolated sub-interpreters that each have their own GIL. */
{Py_mod_multiple_interpreters, Py_MOD_PER_INTERPRETER_GIL_SUPPORTED},
#endif
{0, NULL},
};

static struct PyModuleDef moduledef =
{
.m_base = PyModuleDef_HEAD_INIT,
.m_name = "_frame",
.m_doc = lz4frame__doc,
.m_size = 0,
.m_methods = module_methods,
.m_slots = _frame_slots,
};

PyMODINIT_FUNC
PyInit__frame(void)
{
return PyModuleDef_Init (&moduledef);
}