Fix error handling in frame context creation, reset, and destruction#332
Open
devdanzin wants to merge 1 commit intopython-lz4:masterfrom
Open
Fix error handling in frame context creation, reset, and destruction#332devdanzin wants to merge 1 commit intopython-lz4:masterfrom
devdanzin wants to merge 1 commit intopython-lz4:masterfrom
Conversation
- Remove LZ4F_freeDecompressionContext on failed LZ4F_createDecompressionContext in both create_decompression_context and reset_decompression_context — when creation fails, the context pointer may be invalid and freeing it is UB. - Fix PyErr_SetString with literal "%s" in reset_decompression_context — PyErr_SetString does not do printf-style formatting, so the error message would literally contain "%s" instead of the error code. Removed the inapplicable format specifier. - Add NULL checks in capsule destructors (destroy_compression_context and destroy_decompression_context) — PyCapsule_GetPointer can return NULL if the capsule name doesn't match. Without the check, NULL is dereferenced. Found using cext-review-toolkit (https://github.com/devdanzin/cext-review-toolkit). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LZ4F_freeDecompressionContextcall on failedLZ4F_createDecompressionContextin bothcreate_decompression_contextandreset_decompression_context— when creation fails, the context pointer may be invalid and freeing it is undefined behaviorPyErr_SetStringwith literal"%s"inreset_decompression_context—PyErr_SetStringdoes not do printf-style formatting, so the error message would literally contain%sinstead of the error codedestroy_compression_contextanddestroy_decompression_context) —PyCapsule_GetPointercan return NULL if the capsule name doesn't match; without the check, NULL is dereferencedFound using cext-review-toolkit.
Note
This PR was authored and submitted by Claude Code (Anthropic).
It was reviewed by a human before submission.
Test plan