Skip to content

Fix PyArg_ParseTuple format mismatch and non-NULL return with exception in stream module #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devdanzin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix PyArg_ParseTuple format mismatch and non-NULL return with exception in stream module #331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5867f19
fix: release buffers and free memory on error paths
devdanzin Apr 1, 2026
0957fe1
fix: correct PyArg_ParseTuple format and non-NULL return with excepti…
devdanzin Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lz4/block/_block.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,6 +215,8 @@ compress (PyObject * Py_UNUSED (self), PyObject * args, PyObject * kwargs)
dest = PyMem_Malloc (total_size * sizeof * dest);
if (dest == NULL)
{
PyBuffer_Release(&source);
PyBuffer_Release(&dict);
return PyErr_NoMemory();
}

Expand Down Expand Up @@ -349,6 +351,8 @@ decompress (PyObject * Py_UNUSED (self), PyObject * args, PyObject * kwargs)
dest = PyMem_Malloc (dest_size * sizeof * dest);
if (dest == NULL)
{
PyBuffer_Release(&source);
PyBuffer_Release(&dict);
return PyErr_NoMemory();
}

Expand Down
3 changes: 3 additions & 0 deletions lz4/frame/_frame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ compress (PyObject * Py_UNUSED (self), PyObject * args,
}
else if (block_checksum)
{
PyBuffer_Release(&source);
PyErr_SetString (PyExc_RuntimeError,
"block_checksum specified but not supported by LZ4 library version");
return NULL;
Expand Down Expand Up @@ -383,6 +384,7 @@ compress_begin (PyObject * Py_UNUSED (self), PyObject * args,

if (LZ4F_isError (result))
{
PyMem_Free (destination);
PyErr_Format (PyExc_RuntimeError,
"LZ4F_compressBegin failed with code: %s",
LZ4F_getErrorName (result));
Expand Down Expand Up @@ -1115,6 +1117,7 @@ __decompress(LZ4F_dctx * context, char * source, size_t source_size,
buff = PyMem_Realloc (destination, destination_size);
if (buff == NULL)
{
PyMem_Free (destination);
PyErr_SetString (PyExc_RuntimeError,
"Failed to resize buffer");
return NULL;
Expand Down
3 changes: 2 additions & 1 deletion lz4/stream/_stream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,7 @@ _compress_bound (PyObject * Py_UNUSED (self), PyObject * args)
/* Positional arguments: input_size
* Keyword arguments : none
*/
if (!PyArg_ParseTuple (args, "OI", &input_size))
if (!PyArg_ParseTuple (args, "I", &input_size))
{
goto exit_now;
}
Expand Down Expand Up @@ -1211,6 +1211,7 @@ _compress (PyObject * Py_UNUSED (self), PyObject * args)

if (context->strategy.ops->update_context_after_process (context) != 0)
{
Py_CLEAR (py_dest);
PyErr_Format (PyExc_RuntimeError, "Internal error");
goto exit_now;
}
Expand Down
Loading