Skip to content

Keep the CI matplotlib pick compatible with the numpy pick #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eriknw merged 1 commit into from
Aug 6, 2026
+22 −1
Merged

Keep the CI matplotlib pick compatible with the numpy pick #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test_and_build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ jobs:
pyyaml${yamlver} ${sparse} pandas${pdver} scipy${spver} numpy${npver} ${awkward} \
networkx${nxver} ${numba} ${psg} \
${{ matrix.slowtask == 'pytest_bizarro' && 'black' || '' }} \
${{ matrix.slowtask == 'notebooks' && 'matplotlib nbconvert jupyter "ipython>=7" drawsvg' || '' }} \
${{ matrix.slowtask == 'notebooks' && '"matplotlib${mplver}" nbconvert jupyter "ipython>=7" drawsvg' || '' }} \
${{ steps.sourcetype.outputs.selected == 'upstream' && 'cython' || '' }} \
${{ steps.sourcetype.outputs.selected != 'wheel' && '"graphblas>=7.4"' || '' }} \
${{ contains(steps.pyver.outputs.selected, 'pypy') && 'pypy' || '' }} \
Expand Down
21 changes: 21 additions & 0 deletions scripts/ci_pick_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,19 @@ def apply_constraints(v, pyver, scipy_pool, numba_pool):
# Only the numpy 1.x pools reach here, and those Pythons all have pre-3.5 networkx.
v["networkx"] = random.choice([n for n in NETWORKX_VERSIONS[pyver] if _ver(n) < (3, 5)])

# --- matplotlib / numpy floor (notebooks job) ---

# matplotlib is installed unpinned for the notebooks task. matplotlib 3.11.0's
# runtime check requires numpy >=1.25, but its conda-forge metadata does not,
# so the solver happily pairs matplotlib 3.11 with a numpy 1.24 pin and the
# notebooks then die at `import matplotlib`. Pin below 3.11 whenever the
# numpy pick sits under that floor; empty means latest is fine.
# MAINT: 2026-08-05 confirmed with matplotlib 3.11.0 + numpy 1.24.4
if v["numpy"] and _ver(v["numpy"]) < (1, 25):
v["matplotlib"] = "<3.11"
else:
v["matplotlib"] = ""

# --- numba constraints ---

# numba minimum by Python version: 0.59 for 3.12, 0.61 for 3.13, 0.63 for 3.14
Expand Down Expand Up @@ -380,6 +393,7 @@ def _pick_psg(npver, pyver, source_type):
"sparse": "sparse",
"numba": "numba",
"psg": "psg",
"matplotlib": "mpl",
}


Expand All @@ -401,6 +415,8 @@ def format_output(v):

# psg already has = or == prefix
lines.append(f"psgver='{v['psg']}'")
# matplotlib carries a bare ceiling (e.g. "<3.11") or is empty for latest
lines.append(f"mplver='{v['matplotlib']}'")
return "\n".join(lines)


Expand All @@ -417,6 +433,7 @@ def format_summary(v):
"pyyaml",
"sparse",
"psg",
"matplotlib",
):
name = _SUMMARY_NAMES[key]
val = v[key]
Expand Down Expand Up @@ -482,6 +499,10 @@ def validate(v, pyver):
if not np_is_1x and v["awkward"] not in ("", "NA") and _ver(v["awkward"]) < (2, 6):
errors.append(f"awkward {v['awkward']} doesn't support numpy 2.x")

# matplotlib 3.11 requires numpy >=1.25 at runtime (notebooks job)
if v["numpy"] and _ver(v["numpy"]) < (1, 25) and v.get("matplotlib", "") != "<3.11":
errors.append(f"matplotlib unpinned alongside numpy {v['numpy']} (needs <3.11)")

# awkward <2.10 requires numpy <2.5 (generic-unit datetime64("NaT") at import)
if (
_ver(v["numpy"]) >= (2, 5)
Expand Down
Loading