Skip to content

Test the fmm engine guards, string weights, and config key completions - #609

Open
eriknw wants to merge 2 commits into
28-config-attr-guardfrom
29-io-config-coverage
Open

Test the fmm engine guards, string weights, and config key completions#609
eriknw wants to merge 2 commits into
28-config-attr-guardfrom
29-io-config-coverage

Conversation

@eriknw

@eriknw eriknw commented Aug 4, 2026

Copy link
Copy Markdown
Member

Three behaviors had no test at all in the fast tier. Asking for the
deprecated "fmm"/"fast_matrix_market" Matrix Market engine when
fast_matrix_market is not installed must warn about the deprecation
before it fails, and then fail with an ImportError naming the engine;
neither read nor write had coverage for that, since the existing engine
tests skip themselves when the package is missing. String edge weights
in from_networkx infer a 1-D <U array, so only the dtype-kind half of
the guard sends them down the scipy fallback; the neighboring
array-weight test exercises only the shape half. And the config
mapping's ipython_key_completions hook, which drives config[<tab>]
in IPython, was never called.

Each test was checked by perturbing the line it covers and confirming
it goes red.


Stack created with GitHub Stacks CLIGive Feedback 💬

@eriknw
eriknw marked this pull request as ready for review August 4, 2026 16:07
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from fd8075e to b3592de Compare August 4, 2026 16:12
@eriknw
eriknw force-pushed the 29-io-config-coverage branch 2 times, most recently from 1a9ea9e to 4f77daf Compare August 5, 2026 03:18
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 4f77daf to b496504 Compare August 5, 2026 17:44
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from b496504 to 035b553 Compare August 5, 2026 18:03
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 035b553 to 91d6d15 Compare August 5, 2026 18:05
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 91d6d15 to 7ae8528 Compare August 6, 2026 07:59
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 7ae8528 to 6d95911 Compare August 6, 2026 15:39
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 6d95911 to 5698b2f Compare August 6, 2026 15:41
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 5698b2f to 28e3c0e Compare August 6, 2026 20:36
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 28e3c0e to 236b2a3 Compare August 6, 2026 20:42
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 236b2a3 to 88b96ee Compare August 7, 2026 02:48
eriknw added 2 commits August 7, 2026 00:09
Three behaviors had no test at all in the fast tier. Asking for the
deprecated "fmm"/"fast_matrix_market" Matrix Market engine when
fast_matrix_market is not installed must warn about the deprecation
before it fails, and then fail with an ImportError naming the engine;
neither read nor write had coverage for that, since the existing engine
tests skip themselves when the package is missing. String edge weights
in from_networkx infer a 1-D <U array, so only the dtype-kind half of
the guard sends them down the scipy fallback; the neighboring
array-weight test exercises only the shape half. And the config
mapping's _ipython_key_completions_ hook, which drives `config[<tab>]`
in IPython, was never called.

Each test was checked by perturbing the line it covers and confirming
it goes red.
@eriknw
eriknw force-pushed the 29-io-config-coverage branch from 88b96ee to 7da2c6f Compare August 7, 2026 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant