Test the fmm engine guards, string weights, and config key completions - #609
Open
eriknw wants to merge 2 commits into
Open
Test the fmm engine guards, string weights, and config key completions#609eriknw wants to merge 2 commits into
eriknw wants to merge 2 commits into
Conversation
eriknw
marked this pull request as ready for review
August 4, 2026 16:07
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 4, 2026 16:12
fd8075e to
b3592de
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
2 times, most recently
from
August 5, 2026 03:18
1a9ea9e to
4f77daf
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 5, 2026 17:44
4f77daf to
b496504
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 5, 2026 18:03
b496504 to
035b553
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 5, 2026 18:05
035b553 to
91d6d15
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 6, 2026 07:59
91d6d15 to
7ae8528
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 6, 2026 15:39
7ae8528 to
6d95911
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 6, 2026 15:41
6d95911 to
5698b2f
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 6, 2026 20:36
5698b2f to
28e3c0e
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 6, 2026 20:42
28e3c0e to
236b2a3
Compare
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 7, 2026 02:48
236b2a3 to
88b96ee
Compare
Three behaviors had no test at all in the fast tier. Asking for the deprecated "fmm"/"fast_matrix_market" Matrix Market engine when fast_matrix_market is not installed must warn about the deprecation before it fails, and then fail with an ImportError naming the engine; neither read nor write had coverage for that, since the existing engine tests skip themselves when the package is missing. String edge weights in from_networkx infer a 1-D <U array, so only the dtype-kind half of the guard sends them down the scipy fallback; the neighboring array-weight test exercises only the shape half. And the config mapping's _ipython_key_completions_ hook, which drives `config[<tab>]` in IPython, was never called. Each test was checked by perturbing the line it covers and confirming it goes red.
eriknw
force-pushed
the
29-io-config-coverage
branch
from
August 7, 2026 05:09
88b96ee to
7da2c6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three behaviors had no test at all in the fast tier. Asking for the
deprecated "fmm"/"fast_matrix_market" Matrix Market engine when
fast_matrix_market is not installed must warn about the deprecation
before it fails, and then fail with an ImportError naming the engine;
neither read nor write had coverage for that, since the existing engine
tests skip themselves when the package is missing. String edge weights
in from_networkx infer a 1-D <U array, so only the dtype-kind half of
the guard sends them down the scipy fallback; the neighboring
array-weight test exercises only the shape half. And the config
mapping's ipython_key_completions hook, which drives
config[<tab>]in IPython, was never called.
Each test was checked by perturbing the line it covers and confirming
it goes red.
Stack created with GitHub Stacks CLI • Give Feedback 💬