Skip to content

Stats - #968

Merged
max-wittig merged 4 commits into
python-gitlab:masterfrom
mitar:stats
Dec 13, 2019
Merged

Stats#968
max-wittig merged 4 commits into
python-gitlab:masterfrom
mitar:stats

Conversation

@mitar

@mitar mitar commented Dec 10, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@mitar

mitar commented Dec 10, 2019

Copy link
Copy Markdown
Contributor Author

I have no idea if this is right, but it works. :-)

Comment thread gitlab/v4/objects.py
Comment thread gitlab/v4/objects.py
@max-wittig

Copy link
Copy Markdown
Member

@mitar Thanks for the MR. Would you mind to use the conventional changelog for your commits, add docs and tests?

@max-wittig

Copy link
Copy Markdown
Member

@mitar Nearly complete 👍 Would you mind to just add some tests to this?

@mitar

mitar commented Dec 13, 2019

Copy link
Copy Markdown
Contributor Author

Added tests.

@max-wittig

Copy link
Copy Markdown
Member

@mitar Woah. You're fast. Just format your changes using black and you're good to go after the pipeline passes.

@mitar

mitar commented Dec 13, 2019

Copy link
Copy Markdown
Contributor Author

Done.

@mitar

mitar commented Dec 13, 2019

Copy link
Copy Markdown
Contributor Author

Tests are passing.

@max-wittig

Copy link
Copy Markdown
Member

@mitar Awesome thanks!

@max-wittig
max-wittig merged commit 62b0b62 into python-gitlab:master Dec 13, 2019
@mitar
mitar deleted the stats branch December 13, 2019 17:28
@mitar

mitar commented Dec 13, 2019

Copy link
Copy Markdown
Contributor Author

When would this be released?

@max-wittig

Copy link
Copy Markdown
Member

@mitar I guess I could do another release for you on Monday.

@max-wittig

Copy link
Copy Markdown
Member

@mitar You got a christmas present! 🎄 🎁

https://github.com/python-gitlab/python-gitlab/releases/tag/v1.15.0

Thanks for your contributions!

@mitar

mitar commented Dec 16, 2019

Copy link
Copy Markdown
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants