Skip to content

README.rst: fix the upstream Docker image reference - #958

Merged
max-wittig merged 1 commit into
python-gitlab:masterfrom
vvv:fix-docker-ref
Dec 2, 2019
Merged

README.rst: fix the upstream Docker image reference#958
max-wittig merged 1 commit into
python-gitlab:masterfrom
vvv:fix-docker-ref

Conversation

@vvv

@vvv vvv commented Nov 30, 2019

Copy link
Copy Markdown
Contributor

v1.8.0 is not available.

Unable to find image 'registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0' locally
docker: Error response from daemon: manifest for registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0 not found: manifest unknown: manifest unknown.

@max-wittig

Copy link
Copy Markdown
Member

Thanks for the MR. I would go for latest

@vvv

vvv commented Dec 1, 2019

Copy link
Copy Markdown
Contributor Author

I would go for latest

Done.

@max-wittig

Copy link
Copy Markdown
Member

@vvv Pipeline still fails, because the scope needs to be lowercase. Would you mind to adapt it to

docs(readme): fix docker image reference

Thanks 👍

@vvv

vvv commented Dec 2, 2019

Copy link
Copy Markdown
Contributor Author

We enforce commit messages to be formatted using the conventional-changelog. This leads to more readable messages that are easy to follow when looking through the project history.

This also keeps the barrier to entry for new contributors unnecessarily high.

password requirements

v1.8.0 is not available.
```
Unable to find image 'registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0' locally
docker: Error response from daemon: manifest for registry.gitlab.com/python-gitlab/python-gitlab:v1.8.0 not found: manifest unknown: manifest unknown.
```
@max-wittig

Copy link
Copy Markdown
Member

But makes changelog generation easier ;) and you did it :D

@max-wittig
max-wittig merged commit f6f5178 into python-gitlab:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants