#942: fix up path computation for project-fork list - #943
Merged
max-wittig merged 2 commits intoNov 20, 2019
Conversation
choyrim
force-pushed
the
942-project-fork-list-404
branch
from
November 20, 2019 05:23
d89600d to
44a7c27
Compare
Member
|
@choyrim But don't you delete the |
Contributor
Author
@max-wittig yes that is the end result. I originally just tried to fix the list method but that caused the create to fail. So I noticed that the |
max-wittig
reviewed
Nov 20, 2019
Member
|
Ah I see. Makes sense! Thank you! Just a small comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for #942 - path computation wasn't working.