Skip to content

feat: add methods to retrieve an individual project environment - #865

Merged
max-wittig merged 1 commit into
python-gitlab:masterfrom
orf:retrieve-environment
Aug 22, 2019
Merged

feat: add methods to retrieve an individual project environment#865
max-wittig merged 1 commit into
python-gitlab:masterfrom
orf:retrieve-environment

Conversation

@orf

@orf orf commented Aug 16, 2019

Copy link
Copy Markdown

Gitlab supports this: https://docs.gitlab.com/ce/api/environments.html#get-a-specific-environment

I'm using the same ProjectEnvironment object, even though retrieving an environment has wildly more attributes (including nested ones). Please let me know if I should add anything else to this.

@LaurentDumont

LaurentDumont commented Aug 16, 2019

Copy link
Copy Markdown

What is the status on this? I'd like to get the Pipeline status for the env in question and the default list doesn't have the information :(

@max-wittig

max-wittig commented Aug 16, 2019

Copy link
Copy Markdown
Member

@orf Thanks for your contribution.
Doesn't this disable the listing of environments? Could you please add tests for this feature?

@orf

orf commented Aug 20, 2019

Copy link
Copy Markdown
Author

I've added a test @max-wittig. Let me know what you think!

@max-wittig max-wittig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this MR 👍

@max-wittig
max-wittig merged commit 0389e66 into python-gitlab:master Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants