Skip to content

Fix avatar uploading for projects - #861

Merged
max-wittig merged 1 commit into
python-gitlab:masterfrom
ravanscafi:fix-project-avatar
Aug 22, 2019
Merged

Fix avatar uploading for projects#861
max-wittig merged 1 commit into
python-gitlab:masterfrom
ravanscafi:fix-project-avatar

Conversation

@ravanscafi

@ravanscafi ravanscafi commented Aug 14, 2019

Copy link
Copy Markdown

The avatar attribute was already set for projects but it wasn't working because the type was missing.

@ravanscafi

ravanscafi commented Aug 21, 2019

Copy link
Copy Markdown
Author

@max-wittig could you please take a look?
It's a really simple change, I'm using it and can ensure that it works.

Thanks!

max-wittig
max-wittig approved these changes Aug 22, 2019
View reviewed changes

@max-wittig max-wittig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the MR 👍

@max-wittig
max-wittig merged commit 99a9415 into python-gitlab:master Aug 22, 2019
@ravanscafi
ravanscafi deleted the fix-project-avatar branch August 22, 2019 17:25
@ravanscafi
ravanscafi restored the fix-project-avatar branch August 22, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@max-wittig max-wittig max-wittig approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ravanscafi @max-wittig