Skip to content

chore: release tags to PyPI automatically - #680

Merged
gpocentek merged 1 commit into
masterfrom
chore/automatic-deploy
Jan 19, 2019
Merged

chore: release tags to PyPI automatically#680
gpocentek merged 1 commit into
masterfrom
chore/automatic-deploy

Conversation

@max-wittig

Copy link
Copy Markdown
Member

Fixes #609

@max-wittig max-wittig changed the title chore: release tags to PyPI automatically WIP:chore: release tags to PyPI automatically Jan 13, 2019
@max-wittig
max-wittig force-pushed the chore/automatic-deploy branch from 1a09b70 to 3133b48 Compare January 13, 2019 11:28
@max-wittig max-wittig changed the title WIP:chore: release tags to PyPI automatically chore: release tags to PyPI automatically Jan 13, 2019
@gpocentek

Copy link
Copy Markdown
Contributor

Cool :)

Would it make sense to create a dedicated user on pypi for this? If something goes wrong all your projects on pypi will be impacted.

@max-wittig

Copy link
Copy Markdown
Member Author

Yes that would be even better. What do you mean with goes wrong? The travis secret only effects this repository.

@gpocentek

Copy link
Copy Markdown
Contributor

I'm just trying to consider all the possible problems that could happen.

I don't know how we could handle a "bot user" easily. Any idea on how we should do that?

@max-wittig

Copy link
Copy Markdown
Member Author

It's difficult as we can't handle the secret together. We have no encrypted channel. I guess it would be best, if you would handle the secret for the bot user, as original creator/maintainer.

@max-wittig

Copy link
Copy Markdown
Member Author

@gpocentek Feel free to insert your own/bot-secret secret on this branch.

Use the travis-cli to encrypt it

docker run -v $(pwd):/project --rm skandyla/travis-cli encrypt <your-pypi-passwd> --add deploy.password -r python-gitlab/python-gitlab

@max-wittig

Copy link
Copy Markdown
Member Author

@gpocentek How are we gonna proceed here?

@gpocentek

Copy link
Copy Markdown
Contributor

@max-wittig if that's still OK with you let's merge this, we can update the user later if we find a better solution.

@max-wittig

max-wittig commented Jan 19, 2019

Copy link
Copy Markdown
Member Author

Fine by me

@gpocentek
gpocentek merged commit ca8c85c into master Jan 19, 2019
@max-wittig
max-wittig deleted the chore/automatic-deploy branch January 19, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants