Add support for Project badges - #507
Merged
Merged
Conversation
Miouge1
force-pushed
the
badges
branch
2 times, most recently
from
May 23, 2018 13:06
ae24fa9 to
802b2d4
Compare
gpocentek
suggested changes
May 26, 2018
gpocentek
left a comment
Contributor
There was a problem hiding this comment.
Thanks for this patch!
It would be great to have some functional testing in tools/python_test_v4.py.
And extra points if you can add some documentation.
| _path = '/projects/%(project_id)s/badges' | ||
| _obj_cls = ProjectBadge | ||
| _from_parent_attrs = {'project_id': 'id'} | ||
| _create_attrs = (('link_url', 'image_url'), tuple()) |
Contributor
There was a problem hiding this comment.
It is also possible to update the badge objects, so could you define the _update_attrs variable as well?
| ('triggers', 'ProjectTriggerManager'), | ||
| ('variables', 'ProjectVariableManager'), | ||
| ('wikis', 'ProjectWikiManager'), | ||
| ('badges', 'ProjectBadgeManager'), |
Contributor
There was a problem hiding this comment.
Could you move this line to keep the list sorted?
Contributor
Author
|
@gpocentek thanks for the feedback. Can you review the latest commit, it should add tests, the update_attrs etc... ? |
gpocentek
approved these changes
May 29, 2018
Contributor
|
Thanks! |
Contributor
Author
|
@gpocentek I would love to see this release in a v1.5.0 to start using it in production from PyPi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for project badges https://docs.gitlab.com/ee/api/project_badges.html