Skip to content

Chore/changelog format - #2697

Merged
nejch merged 2 commits into
mainfrom
chore/changelog-format
Oct 18, 2023
Merged

Chore/changelog format#2697
nejch merged 2 commits into
mainfrom
chore/changelog-format

Conversation

@nejch

@nejch nejch commented Oct 18, 2023

Copy link
Copy Markdown
Member

The latest python-semantic-release has completely changed the format and includes chores etc, including for old releases, making the diff unreasonable. First, let's bring the old format back.

Follow-up to #2693, #2692.

The real diff for v4.0.0 changelog then becomes this:

3e20a76...chore/changelog-format

@JohnVillalovos JohnVillalovos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@JohnVillalovos

Copy link
Copy Markdown
Member

@nejch Approved. Feel free to merge when you are ready.

@codecov

codecov Bot commented Oct 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #2697 (63e9c8b) into main (7b19278) will increase coverage by 4.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2697      +/-   ##
==========================================
+ Coverage   92.23%   96.43%   +4.19%     
==========================================
  Files          88       88              
  Lines        5747     5747              
==========================================
+ Hits         5301     5542     +241     
+ Misses        446      205     -241     
Flag Coverage Δ
api_func_v4 82.35% <ø> (?)
cli_func_v4 83.46% <ø> (ø)
unit 88.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 36 files with indirect coverage changes

@nejch

nejch commented Oct 18, 2023

Copy link
Copy Markdown
Member Author

Thanks @JohnVillalovos!

@nejch
nejch merged commit 258a751 into main Oct 18, 2023
@nejch
nejch deleted the chore/changelog-format branch October 18, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants