Skip to content

refactor: move the request call to the backend - #2413

Merged
nejch merged 1 commit into
python-gitlab:mainfrom
lmilbaum:http_request
Dec 10, 2022
Merged

refactor: move the request call to the backend#2413
nejch merged 1 commit into
python-gitlab:mainfrom
lmilbaum:http_request

Conversation

@lmilbaum

@lmilbaum lmilbaum commented Dec 6, 2022

Copy link
Copy Markdown

No description provided.

@lmilbaum
lmilbaum force-pushed the http_request branch 10 times, most recently from ce8e6b7 to bff0116 Compare December 7, 2022 03:47
@lmilbaum
lmilbaum marked this pull request as ready for review December 7, 2022 04:04

@nejch nejch left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lmilbaum, just a few initial questions on the typing here.

Comment thread gitlab/http_backends/requests_backend.py Outdated
Comment thread gitlab/http_backends/requests_backend.py
@lmilbaum
lmilbaum requested review from nejch and removed request for nejch December 10, 2022 12:16
Comment thread gitlab/http_backends/requests_backend.py Outdated
@nejch
nejch enabled auto-merge (squash) December 10, 2022 13:02
@nejch nejch changed the title refactor: Moving the request call to the backend refactor: move the request call to the backend Dec 10, 2022
@nejch
nejch merged commit 283e7cc into python-gitlab:main Dec 10, 2022
@lmilbaum
lmilbaum deleted the http_request branch December 10, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants