fix: avoid passing redundant arguments to API#1965
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1965 +/- ##
=======================================
Coverage 92.56% 92.56%
=======================================
Files 78 78
Lines 4909 4910 +1
=======================================
+ Hits 4544 4545 +1
Misses 365 365
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@nejch Mhmm but where is that |
@max-wittig previously it would just get picked from the method's python-gitlab/gitlab/client.py Lines 680 to 682 in 3b0806e but all kwargs are passed as query parameters to the API because they're copied to params earlier: python-gitlab/gitlab/client.py Line 669 in 3431887 I added it as an explicit argument to avoid that. I could have done |
Closes #987.
This was already fixed in b9ecc9a but partially reintroduced with the global
retry_transient_errorsfeature.