Skip to content

docs:Small docs fixup for application scopes - #1951

Merged
nejch merged 1 commit into
python-gitlab:mainfrom
wacuuu:main
Mar 30, 2022
Merged

docs:Small docs fixup for application scopes#1951
nejch merged 1 commit into
python-gitlab:mainfrom
wacuuu:main

Conversation

@wacuuu

@wacuuu wacuuu commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

Hi all,

I found a small hickup in the docs that took me a few minutes to understand. Looking at API docs and the code I have found out that the way we try to push the application scopes doesn't match the API. I'd like to leave an appropriate example in docs so that people don't get stuck on this

@wacuuu wacuuu changed the title Small docs fixup for application scopes docs:Small docs fixup for application scopes Mar 28, 2022
@nejch

nejch commented Mar 30, 2022

Copy link
Copy Markdown
Member

Thanks for the catch @wacuuu! Surprised to see they're using space-delimited strings here, in most other places they use arrays for scopes which is why it was documented like that.

Could you please rebase again as there was a recent broken version of black that breaks our CI? psf/black#2964.

@wacuuu

wacuuu commented Mar 30, 2022

Copy link
Copy Markdown
Contributor Author

Oh, so that is why linter broke. I couldn't understand what is wrong.

@nejch
nejch enabled auto-merge March 30, 2022 08:22
@nejch
nejch merged commit 8e241e4 into python-gitlab:main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants