Skip to content

Convert response list to single data source for iid requests #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpocentek merged 1 commit into from
Oct 23, 2016
Merged

Convert response list to single data source for iid requests #169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions gitlab/objects.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,22 @@ def __init__(self, gl, data=None, **kwargs):
data = self.gitlab.get(self.__class__, data, **kwargs)
self._from_api = True

# the API returned a list because custom kwargs where used
# instead of the id to request an object. Usually parameters
# other than an id return ambiguous results. However in the
# gitlab universe iids together with a project_id are
# unambiguous for merge requests and issues, too.
# So if there is only one element we can use it as our data
# source.
if 'iid' in kwargs and isinstance(data, list):
if len(data) < 1:
raise GitlabGetError('Not found')
elif len(data) == 1:
data = data[0]
else:
raise GitlabGetError('Impossible! You found multiple'
' elements with the same iid.')

self._set_from_dict(data, **kwargs)

if kwargs:
Expand Down