chore: add type-hints to gitlab/v4/objects/groups.py - #1668
Merged
Conversation
JohnVillalovos
force-pushed
the
jlvillal/mypy_groups
branch
from
November 6, 2021 04:20
b5ef520 to
8fce110
Compare
Codecov Report
@@ Coverage Diff @@
## main #1668 +/- ##
==========================================
+ Coverage 91.99% 92.01% +0.01%
==========================================
Files 75 75
Lines 4337 4343 +6
==========================================
+ Hits 3990 3996 +6
Misses 347 347
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
reviewed
Nov 6, 2021
nejch
left a comment
Member
There was a problem hiding this comment.
Thanks again @JohnVillalovos just one little question :)
JohnVillalovos
force-pushed
the
jlvillal/mypy_groups
branch
from
November 6, 2021 15:37
8fce110 to
f91ab03
Compare
JohnVillalovos
force-pushed
the
jlvillal/mypy_groups
branch
2 times, most recently
from
November 6, 2021 18:23
9cb07b3 to
65f2bea
Compare
JohnVillalovos
commented
Nov 6, 2021
JohnVillalovos
force-pushed
the
jlvillal/mypy_groups
branch
from
November 7, 2021 16:46
65f2bea to
335a7eb
Compare
* Add type-hints to gitlab/v4/objects/groups.py * Have share() function update object attributes. * Add 'get()' method so that type-checkers will understand that getting a group is of type Group.
JohnVillalovos
force-pushed
the
jlvillal/mypy_groups
branch
from
November 7, 2021 18:55
335a7eb to
94dcb06
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.